Issue Details (XML | Word | Printable)

Key: XW-534
Type: Task Task
Status: Reopened Reopened
Priority: Major Major
Assignee: tm_jee
Reporter: tm_jee
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
XWork

Updgrate Ognl dependency to 2.7 for XWork 1.2.3 release

Created: 30/Jun/07 11:44 AM   Updated: 13/Jun/08 06:06 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.4


 Description  « Hide
Updgrate Ognl dependency to 2.7 for XWork 1.2.3 release

Martin just pointed out there's a new version of ognl that have significant improvements, we might need to use the Ognl.compileExpression() to take advantage of the new speed improvement.

[1] - http://forums.opensymphony.com/thread.jspa?messageID=163582&#163582
[2] - http://www.theserverside.com/news/thread.tss?thread_id=45954

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
tm_jee added a comment - 14/Jul/07 10:07 PM

Rainer Hermanns made changes - 18/Jul/07 03:35 AM
Field Original Value New Value
Fix Version/s 1.2.3 [ 21701 ]
Fix Version/s 1.2.4 [ 21713 ]
tm_jee made changes - 23/Nov/07 09:53 AM
Status Open [ 1 ] In Progress [ 3 ]
tm_jee added a comment - 25/Nov/07 09:21 AM
Fixed. Changes are at :-

Adding java/com/opensymphony/xwork/XWorkConstants.java
Sending java/com/opensymphony/xwork/util/CompoundRootAccessor.java
Sending java/com/opensymphony/xwork/util/ObjectProxyPropertyAccessor.java
Sending java/com/opensymphony/xwork/util/OgnlUtil.java
Sending test/com/opensymphony/xwork/util/CompoundRootPropertyAccessorTest.java
Sending test/com/opensymphony/xwork/util/MyPrimitiveArrayObject.java
Transmitting file data ......
Committed revision 1684.

Kindly review. Cheers.

tm_jee added a comment - 25/Nov/07 09:23 AM
The ognl expression compilation mode is off by default. By default it will use expression parsing. To turn it on we need to use

<xwork>
   <parameters>
             <parameter name="useOgnlEnhancement" value="true" />
    </parameters>
</xwork>

if expression compilation mode failed (throws expression) it will fallback to expression parsing.


tm_jee added a comment - 25/Nov/07 09:49 AM
Kindly review. :-)

Cheers.

tm_jee made changes - 25/Nov/07 09:49 AM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Rainer Hermanns added a comment - 13/Jun/08 06:06 AM
code does not work when feature is enabled...
Lots of failing unit tests...

See my additional mail for more information.

Rainer Hermanns made changes - 13/Jun/08 06:06 AM
Status Resolved [ 5 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]