History | Log In     View a printable version of the current page.  
   HOME       BROWSE PROJECT       FIND ISSUES   
    QUICK SEARCH:  
Issue Details (XML | Word | Printable)

Key: XW-473
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Claus Ibsen
Reporter: Musachy Barroso
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
XWork

Add RFC3339 date support to XWorkBasicConverter

Created: 31/Jan/07 09:59 AM   Updated: 13/Apr/07 10:22 AM
Component/s: Type Conversion
Affects Version/s: None
Fix Version/s: 1.2.2, 2.0.1

File Attachments: 1. Text File WW-1643.patch (3 kb)
Issue Links:
Related
This issue relates to:
XW-507 XWorkBasicConvert - RFC3339 not threa... Major Resolved
 

Flags: Patch


 Description  « Hide
The dojo widgets use the standard RFC3339 as the date format. The XWorkBasicConverter tries to parse a date using the constants defined on DateFormat: SHORT,MEDIUM LONG. Add RFC 3339 to this list.

 All   Comments   Change History      Sort Order:
[ Permlink | « Hide ]
Musachy Barroso - [31/Jan/07 10:00 AM ]
If applied please update:
https://issues.apache.org/struts/browse/WW-1643

[ Permlink | « Hide ]
Philip Luppens - [01/Feb/07 05:31 AM ]
Applied. Thanks Musachy.

[ Permlink | « Hide ]
Claus Ibsen - [12/Apr/07 02:28 PM ]
Isn't the privat static final SimpleDateFormatter not thread-safe? And thus should be change to a object created on need instead.

[ Permlink | « Hide ]
Philip Luppens - [12/Apr/07 02:39 PM ]
Indeed, I wasn't aware it was not (but I just looked it up, and you're correct). I'll reopen the issue.

[ Permlink | « Hide ]
Philip Luppens - [12/Apr/07 02:40 PM ]
As Claus noted, the current implementation is not thread-safe.

[ Permlink | « Hide ]
Musachy Barroso - [12/Apr/07 02:44 PM ]
By the way, the real name is RFC3339, can you rename it? :)

[ Permlink | « Hide ]
Philip Luppens - [12/Apr/07 02:49 PM ]
Renamed issue, will do the same in the code. Thanks for letting me know :-)

[ Permlink | « Hide ]
Claus Ibsen - [13/Apr/07 03:55 AM ]
The fix should be merged to the trunk also

[ Permlink | « Hide ]
Philip Luppens - [13/Apr/07 04:08 AM ]
Yeah, it should be correct in all branches and trunk. Claus, feel free to reassign the issue and fix it. I currently don't have access to the svn repo, and I'm short on time.

[ Permlink | « Hide ]
Claus Ibsen - [13/Apr/07 10:03 AM ]
Fixed in trunk at rev 1474

[ Permlink | « Hide ]
Claus Ibsen - [13/Apr/07 10:10 AM ]
Fixed in 2.0 branch at rev 1475

[ Permlink | « Hide ]
Claus Ibsen - [13/Apr/07 10:22 AM ]
Created new ticket XW-507 for the thread-safe issue.

Will close this one.


Powered by a free Atlassian JIRA non-profit license for OpenSymphony. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.8-#209) - Bug/feature request - Contact Administrators