History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: WW-414
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Jonas Eriksson
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
WebWork

multipart encoding bug...?

Created: 03/Dec/03 05:38 PM   Updated: 08/Jan/04 03:22 AM
Component/s: Dispatch
Affects Version/s: 2.0-beta2
Fix Version/s: 2.0


 Description  « Hide
Multipart encoding is hardcoded to utf-8 in PellMultiPartRequest. Can't be correct... but maybe it can be written over somewhere else?

The following block is commented out in source. (setEncoding())
---
  /*
        String encoding = null;
        try {
            //encoding = Configuration.getString("webwork.i18n.encoding");
            if (encoding != null) {
                //NB: This should never be called at the same time as the constructor for
                //ServletMultiPartRequest, as it can cause problems.
                //See javadoc for MultipartRequest.setEncoding()
                http.utils.multipartrequest.MultipartRequest.setEncoding(encoding);
            }
       
---


From email:

Please submit a bug report and we'll get on it... You're probably the
first one to stumble on it

BTW, this stuff is exactly the same as in WW1.3 and 1.4, so we'll need
to fix this there, too...

Jason



 All   Comments   Change History      Sort Order:
Mike Cannon-Brookes - [07/Jan/04 08:08 PM ]
Jonas,

This should be fixed in CVS - can you let me know how it works for you?

The encoding is set to look for webwork.i18n.encoding property, and if that's not found then UTF-8 is used by default.

Cheers,
Mike

Jonas Eriksson - [08/Jan/04 03:22 AM ]
It's not working.
I can see an addition of getEncoding() in WebWorkVelocityServlet but that does not change anything. In PellMultipartRequest the code above is uncommented but the Configuration.getString(..) is still commented?!

Uncomment that line and it will work.

Another thing I should mention is that I got an exception if I didn't specify webwork.multipart.parser (unlike before where pell was default)