[#WW-1477] RestfulActionMapper getMapping and getUriFromMapping methods conflicts

WebWork

RestfulActionMapper getMapping and getUriFromMapping methods conflicts

Created: 08/Sep/07 09:54 AM Updated: 12/Nov/07 09:53 AM

Component/s:

None

Affects Version/s:

2.2.6

Fix Version/s:

2.2.7

Issue Links:

Related

This issue relates to:
	~~WW-1478~~ URL and Form Tag doesn't generate url...

Description

« Hide

Currently in RestfulActionMapper, there's some conflict in the implementation of
- getMapping(HttpServletRequest)
- getUriFromMapping(ActionMapping)
methods.

getMapping will returns an ActionMapping with parameters say if we have url like
/actionName/param1/value1/param2/value2
it will return an ActionMapping with parameters :-
- param1=value1
- param2=value2

If we try to get the uri with the ActionMapping above, we get an ActionMapping without any parameters.

I think getMapping and getUriFromMapping should be compliant with each other.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

tm_jee - [08/Sep/07 12:31 PM ]

fixed. Details at:-

tmjee@tmjee-laptop:~/development/webwork-svn/src$ svn commit test/com/opensymphony/webwork/dispatcher/mapper/RestfulActionMapperTest.java java/com/opensymphony/webwork/dispatcher/mapper/RestfulActionMapper.java
Sending java/com/opensymphony/webwork/dispatcher/mapper/RestfulActionMapper.java
Sending test/com/opensymphony/webwork/dispatcher/mapper/RestfulActionMapperTest.java
Transmitting file data ..
Committed revision 2953.

Kindly review. Thx.

[ Permlink | « Hide ]

tm_jee - [12/Nov/07 09:52 AM ]

Fixed, changes are :-

Sending java/com/opensymphony/webwork/components/Component.java
Sending java/com/opensymphony/webwork/components/Form.java
Sending java/com/opensymphony/webwork/dispatcher/mapper/ActionMapper.java
Adding java/com/opensymphony/webwork/dispatcher/mapper/ActionMappingEx.java
Sending java/com/opensymphony/webwork/dispatcher/mapper/DefaultActionMapper.java
Sending java/com/opensymphony/webwork/dispatcher/mapper/RestfulActionMapper.java
Sending java/com/opensymphony/webwork/views/util/UrlHelper.java
Sending test/com/opensymphony/webwork/dispatcher/ServletRedirectResultTest.java
Sending test/com/opensymphony/webwork/dispatcher/mapper/DefaultActionMapperTest.java
Sending test/com/opensymphony/webwork/dispatcher/mapper/RestfulActionMapperTest.java
Sending test/com/opensymphony/webwork/views/jsp/WebWorkMockPageContext.java
Sending test/com/opensymphony/webwork/views/jsp/ui/FormTagTest.java
Transmitting file data ............
Committed revision 2962.