[#WW-1458] Support Freemarker template_exception_handler=rethrow

WebWork

Support Freemarker template_exception_handler=rethrow

Created: 05/May/07 08:00 AM Updated: 06/May/07 04:35 AM

Component/s:

Views

Affects Version/s:

2.2.5

Fix Version/s:

2.2.6

File Attachments:	1. RethrowHandlingFreemarkerResult.java (9 kB)
Environment:	WebWork 2.2.5, Jetty 6.1.3, OSX 10.4

Flags:

Important, Patch

Description

« Hide

This is the same improvement as requested for Struts 2
http://issues.apache.org/struts/browse/WW-1808

Rather than use the suggested flag I have simply buffered all content, as was currently done when the wrtier was unavailable. If no exceptions occur then the content is written out. If any exceptions are rethrown by the freemarker template then they are simply passed up and handled by the exception interceptor. If none occur the template result is sent down the writer or output stream.

All

Comments

Change History

Sort Order:

Martin Gilday made changes - 05/May/07 08:01 AM

Field	Original Value	New Value
Attachment		RethrowHandlingFreemarkerResult.java [ 12975 ]

[ Permlink | « Hide ]

tm_jee added a comment - 06/May/07 04:32 AM

Hi guys,

Fixed this issue as mentioned in the Struts2 (WW-1808).

The changes are at :-
tmjee@tmjee-laptop:~/development/webwork-svn/src$ svn commit test/com/opensymphony/webwork/views/freemarker/FreemarkerResultTest.java java/com/opensymphony/webwork/views/freemarker/FreemarkerResult.java
Sending java/com/opensymphony/webwork/views/freemarker/FreemarkerResult.java
Adding test/com/opensymphony/webwork/views/freemarker/FreemarkerResultTest.java
Transmitting file data ..
Committed revision 2911.

Hi Martin and Jasper,

Please go through the patch if you got the time to spare, and feel free to reopen this issue if there's anything missed out.

Cheers guys

tm_jee made changes - 06/May/07 04:35 AM

Assignee

tm_jee [ tm_jee ]

tm_jee made changes - 06/May/07 04:35 AM

Resolution		Fixed [ 1 ]
Fix Version/s		2.2.6 [ 21702 ]
Status	Open [ 1 ]	Resolved [ 5 ]