Issue Details (XML | Word | Printable)

Key: WW-1450
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Andreas Knecht
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
WebWork

GenericDispatcher holds on to reference of the oldContextTable when finalizeContext() is called

Created: 15/Apr/07 08:49 PM   Updated: 16/Apr/07 06:51 PM
Component/s: Dispatch, Value Stack
Affects Version/s: 1.4
Fix Version/s: 1.4.1


 Description  « Hide
The GenericDispatcher should null the oldContextTable reference in the finalizeContext() call, to make sure that it doesn't hangon to anything. Otherwise, this may introduce memory leaks, when the GenericDispatcher doesn't get release (if for example, the JspRuntimeContext in Tomcat hangs on to the ActionTag with a GenericDispatcher).

For more details see [JRA-12549|http://jira.atlassian.com/browse/JRA-12549].

Here's a patch:
{noformat}
Index: GenericDispatcher.java
===================================================================
RCS file: /cvsroot/opensymphony/webwork/src/main/webwork/dispatcher/GenericDispatcher.java,v
retrieving revision 1.21
diff -r1.21 GenericDispatcher.java
223a224,226
> //JRA-12549: Null the oldContext here to avoid leaking references to various managers when the
> //GenericDispatcher is held onto by an ActionTag.
> oldContextTable = null;
{noformat}

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
tm_jee added a comment - 15/Apr/07 09:06 PM
This is the link to Andreas's blog where the issue is describes in more detailed

http://blogs.atlassian.com/developer/2007/04/4_more_days_in_a_leaky_boat.html

tm_jee added a comment - 16/Apr/07 06:51 PM
Hani have checked the patch in. Thx guys

tm_jee made changes - 16/Apr/07 06:51 PM
Field Original Value New Value
Resolution Fixed [ 1 ]
Fix Version/s 1.4.1 [ 21260 ]
Status Open [ 1 ] Resolved [ 5 ]