[#WW-1413] Numerical String as KeyProperty in Collection Type Conversion causes NPE (and sometimes ognl Exception).

WebWork

Numerical String as KeyProperty in Collection Type Conversion causes NPE (and sometimes ognl Exception).

Created: 08/Jan/07 05:06 PM Updated: 04/Feb/07 03:54 PM

Component/s:

None

Affects Version/s:

2.2.4

Fix Version/s:

2.2.5

File Attachments:	1. Item.java (0.9 kb) 2. itemList.jsp (0.4 kb) 3. itemListForm.jsp (0.6 kb) 4. MakeItemList.java (1 kb) 5. UpdateItemList-conversion.properties (0.1 kb) 6. UpdateItemList.java (0.8 kb) 7. webwork.properties (0.7 kb) 8. xwork.xml (0.7 kb)
Environment:	« Hide Tomcat 5.5.20 (running on Java 1.5) WebWork 2.2.4 Spring 2.0 Show » Tomcat 5.5.20 (running on Java 1.5) WebWork 2.2.4 Spring 2.0

Description

« Hide

When String was used as KeyProperty in Collection Type Conversion, some values of the KeyProperty caused NPE and sometimes ognl.ExpressionSyntaxException as well.

Some values of KeyProperty that was proven to cause Exceptions are: "08", "09", "a8", "a9", "a5"

Discussions on this issue and examples of Exceptions produced can be found at http://forums.opensymphony.com/thread.jspa?threadID=50841&tstart=0

Code to reproduce this behaviour is attached.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Timothy Wonil Lee - [08/Jan/07 05:16 PM ]

If anyone would like to see more example code, I can upload more. Just let me know by leaving a comment. Thanks!

[ Permlink | « Hide ]

Tom Schneider - [04/Feb/07 10:51 AM ]

The ognl expressions that you are generating are invalid. The ognl expression that was failing compilation was:

itemList(09).desc

I don't think itemList(03).desc is truly valid either, but it doesn't fail compilation. The way to fix this is to add the single quotes needed so ognl treats the 09 as a string:

itemList('09').desc

so the jsp would look like this (itemListForm.jsp):
<ww:textfield label="%{#status.index} - Item Id" name="itemList('%{id}').id" value="%{id}"/>
<ww:textfield label="Item Desc" name="itemList('%{id}').desc" value="%{desc}"/>

This made the test code work.

[ Permlink | « Hide ]

Timothy Wonil Lee - [04/Feb/07 03:54 PM ]

Wow! So that was the problem! Thank you Tom!