Issue Details (XML | Word | Printable)

Key: WW-1249
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Don Brown
Reporter: tm_jee
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
WebWork

FileUploadInterceptor not using internationalized error message

Created: 17/Mar/06 12:02 PM   Updated: 17/Mar/06 10:03 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 2.2.2


 Description  « Hide
FileUploadInterceptor not using internationalized error message, in acceptFile(...) method when File is null, it should use webwork.messages.error.uploading, as listed in javadoc.

validation.addFieldError(inputName, "Could not upload file");

should, i guess, instead be,

validation.addFieldError(inputName,
                 getTextMessage("webwork.messages.error.uploading",
                 new Object[] { "Could not upload file with input name ["+inputName+"]" },
                 locale));

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Claus Ibsen added a comment - 17/Mar/06 04:22 PM
+1 well spotted

Should we list the field name in the default text also?
    "Could not upload file with input name ["+inputName+"]"
could just be
    "Could not upload file"

Don Brown added a comment - 17/Mar/06 04:44 PM
I can fix this real quick...

tm_jee added a comment - 17/Mar/06 10:03 PM
Claus,
   yup, we could, sounds good either way to me.

Don,
Thanks, that's really quick :-)