[#WW-1236] Missing test for null 'action' property in start() of URL component?

WebWork

Missing test for null 'action' property in start() of URL component?

Created: 12/Mar/06 11:41 AM Updated: 14/Dec/06 02:31 PM

Component/s:

Views

Affects Version/s:

2.2.1

Fix Version/s:

2.2.2

Issue Links:

Related

This issue relates to:

~~WW-1266~~ URL tag - includeParams default is "none", but docs states "get" is the default

This issue is related to:

~~WW-1224~~ Portlet URL support doesn't follow JSR-168 spec

Description

« Hide

in the URL component, there's a check if the 'includeParameters' and 'value' properties are null, and if this is the case, it's treated as if 'includeParameters' is set to 'GET'. This causes incorrect behaviour when deploying the sample portlets in uPortal, since the 'action' property is used instead of the 'value' property. The test looks like this:

if ((includeParams == null && value == null) || GET.equalsIgnoreCase(includeParams)) {

Is a test for 'action' == null deliberately left out of this, or is it a bug?

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Nils-Helge Garli added a comment - 13/Mar/06 04:08 PM

Fixed in CVS

[ Permlink | « Hide ]

Nils-Helge Garli added a comment - 16/Mar/06 05:32 AM

Hm...this is the line that's invoked:

else if (value == null && !NONE.equalsIgnoreCase(includeParams)) {
LOG.warn("Unknown value for includeParams parameter to URL tag: " + includeParams);
}

I guess a test for action == null should be added there as well.

[ Permlink | « Hide ]

Alexandru Popescu added a comment - 16/Mar/06 05:45 AM

I've looked at that line before posting for quite a while, and I checked most of my ww.url usages. Still, I cannot figure out what is the problem and when it is invoked. I will probably have to set a breakpoint and figure out from the invocation stack what's wrong.

I will get back to this, when I will have more info.

./alex
--
.w( the_mindstorm )p.