[#WW-1114] Stack overflow bug fix implemented incorrectly?

WebWork

WW-1083

Stack overflow bug fix implemented incorrectly?

Created: 23/Jan/06 09:56 AM Updated: 26/Jan/06 02:45 AM

Component/s:

None

Affects Version/s:

2.2

Fix Version/s:

2.2.1

Flags:

Patch

Description

« Hide

Refer to my comments in the parent task:
http://jira.opensymphony.com/browse/WW-1083

I would like someone to look over the solution that I proposed in the parent task. I think that the fix that was put into place will only fix certain scenarios of the problem and isn't the technically correct implementation of the bug fix.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

tm_jee added a comment - 24/Jan/06 12:25 AM

Thanks for the very detailed explanation. :-) Fixed as pointed out by Brian. Made some alteration to get findAncestor(Class) method.

changes are
src/java/com/opensymphony/webwork/components/ActionComponent.java
src/java/com/opensymphony/webwork/components/Component.java
src/java/com/opensymphony/webwork/components/ElseIf.java
src/java/com/opensymphony/webwork/components/Form.java
src/java/com/opensymphony/webwork/components/IteratorComponent.java
src/java/com/opensymphony/webwork/components/UIBean.java
src/test/com/opensymphony/webwork/views/jsp/ui/FormTagTest.java
src/test/com/opensymphony/webwork/components/ComponentTest.java

Brian, if you don't mind cross check the code. Thx & Cheers ! :-)

[ Permlink | « Hide ]

Brian Lenz added a comment - 24/Jan/06 11:08 AM

I did a review of the code, and it looks good to me! Good correction on the findAncestor() recommendation I made. I wrote it up on the whiteboard incorrectly (not realizing that search() returns 1 for the top of the stack).

Thanks for your work on this!

[ Permlink | « Hide ]

Rainer Hermanns added a comment - 24/Jan/06 05:09 PM

Brian,
so, can this issue be closed?

[ Permlink | « Hide ]

Brian Lenz added a comment - 24/Jan/06 05:12 PM

Yeah, from my perspective it looks good to go :)

[ Permlink | « Hide ]

Rainer Hermanns added a comment - 24/Jan/06 05:14 PM

Ok, thanks

[ Permlink | « Hide ]

tm_jee added a comment - 24/Jan/06 10:47 PM

lovely thanks guys

[ Permlink | « Hide ]

tm_jee added a comment - 26/Jan/06 02:45 AM

missed out to call pop the iterator component in IteratorComponent's start(Writer) method when the body of the iterator is not rendered. Found this when writing some test cases for IteratorComponent.

added the above mentioned issue and more test cases. changes are as follows:

src/test/com/opensymphony/webwork/components/UIComponentTest.java src/test/com/opensymphony/webwork/components/tempo.properties src/test/com/opensymphony/webwork/components/ComponentTest.java src/java/com/opensymphony/webwork/components/IteratorComponent.java