History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SIM-55
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Assignee: Scott Farquhar
Reporter: Scott Farquhar
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
SiteMesh

applyDecorator tag doesn't work on resin

Created: 15/Jan/03 05:52 PM   Updated: 01/Feb/04 10:01 PM
Fix Version/s: 2.1


 Description  « Hide
The applyDecorator tag calls 'release()' manually, which clears the tag values.

As resin caches the values applied to the tags, this results in null errors.

This is explained in the mailing list post by Eric Kreiser on 15/1/03 to sitemesh mailing list:

"I had a problem with UTF-8 content when pulled thru the page:applyDecorator process.

The problem for me was directly related to doing multiple page:applyDecorator calls in a single page. The first call would render the UTF-8 content correctly, but all subsequent calls were miss handled. The first time the taglib is called the ContentType and Encoding is set correctly, but the second time the taglib is called the ContentType and Encoding is not set. And since the "release" method of ApplyDecoratorTag sets the ContentType and Encoding to null, they remain null for the second and subsequent calls - causing the content to be handled as 8859-1."


 All   Comments   Change History      Sort Order:
Mathias Bogaert - [02/Sep/03 02:44 AM ]
I'm not seeing this on Resin 2.1.10. Is this still a valid bug?

Scott Farquhar - [02/Sep/03 02:49 AM ]
Yep. Have two applyDecorator tags on the same page, with the same parameters, and you'll see the problem.

This is because we manually call release() (which we shouldn't!)