[#SIM-168] error pages aren't decorated with Tomcat 5

SiteMesh

error pages aren't decorated with Tomcat 5

Created: 11/Feb/05 10:28 AM Updated: 31/Jul/08 06:58 AM

Fix Version/s:

2.4

File Attachments:	1. sitemesh-test.war (155 kb)
Environment:	Tomcat 5.5, SiteMess 2.2.1, JDK 1.5.1, Windows XP

Description

« Hide

I saw on the FAQ that there was supposedly a solution to this but it didn't work.

I've also tried adding ERROR to the dispatch list with no joy.

<filter-mapping>
<filter-name>sitemesh</filter-name>
<url-pattern>/*</url-pattern>
<dispatcher>FORWARD</dispatcher>
<dispatcher>REQUEST</dispatcher>
<dispatcher>ERROR</dispatcher>
</filter-mapping>

Is this fixed in a later version? All my other pages are decorated as expected.

Kevin

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Georg Mueller - [02/Dec/05 02:51 AM ]

I am using sitemesh together with struts, tomcat 5.0 or tomcat 5.5 (tested both) and have the same problems.

The funny thing is that my 403 page _does_ get decorated, while my 404 and 500 pages do not.

[ Permlink | « Hide ]

Daniel Serodio - [19/Dec/06 01:01 PM ]

[ Permlink | « Hide ]

Scott Farquhar - [08/Jan/07 12:12 AM ]

Has been committed. People using sitemesh will need to test their error pages to ensure that any workarounds still work.

[ Permlink | « Hide ]

Ian Taylor - [14/Feb/07 01:28 AM ]

Having this problem with cvs as of 2007.02.14 under Jetty 6.1.2pre1

[ Permlink | « Hide ]

Graeme Rocher - [19/Nov/07 06:29 AM ]

We have the same problem in Grails (http://grails.org) however neither of the proposed solutions work. When debugging it seems that PageResponseWrapper sets sitemesh to abort when sendError is called on the response. This results in sitemesh never applying a layout.

I'm testing on Jetty 6. Any ideas?

[ Permlink | « Hide ]

Darren Davison - [15/Apr/08 08:52 AM ]

is there a release date proposed for 2.4 ? We're hitting this issue on tomcat6 and the proposed workaround from the wiki linked above doesn't work.

[ Permlink | « Hide ]

Scott Farquhar - [03/May/08 03:23 AM ]

Darren,

Can you check out HEAD, and let me know if it solves your problem?

http://www.opensymphony.com/sitemesh/cvs.action

Cheers,
Scott

[ Permlink | « Hide ]

Darren Davison - [04/May/08 01:53 PM ]

Hi Scott,

I get the same behaviour as I do in 2.3. With a 404 response code and the following web.xml stanzas, the page remains undecorated:

<filter>
  <filter-name>sitemesh</filter-name>
  <filter-class>com.opensymphony.module.sitemesh.filter.PageFilter</filter-class>
</filter>
...
<filter-mapping>
  <filter-name>sitemesh</filter-name>
  <url-pattern>/*</url-pattern>
  <dispatcher>REQUEST</dispatcher>
  <dispatcher>FORWARD</dispatcher>
  <dispatcher>ERROR</dispatcher>
</filter-mapping>
...
<error-page>
  <error-code>404</error-code>
  <location>/WEB-INF/jsp/404.jsp</location>
</error-page>

Cheers,
Darren

[ Permlink | « Hide ]

Scott Farquhar - [05/May/08 02:23 PM ]

Darren,

Can you attach a very simple war file that demonstrates your problem? That would make me sure that any solution I work on fixes your specific problem.

[ Permlink | « Hide ]

Darren Davison - [06/May/08 04:12 AM ]

Scott, attached is a .war that exhibits the same problem as I see in our project when running on Tomcat 6.0.14.

Cheers,

[ Permlink | « Hide ]

Darren Davison - [06/May/08 04:59 AM ]

just for completeness, my environment is:
OS: Linux 2.6.24
JDK: BEA jrockit-R27.4.0
SERVER: Tomcat 6..0.14
LIB: Sitemesh 2.4 SNAPSHOT compiled from CVS HEAD on 4/May/08

[ Permlink | « Hide ]

Scott Farquhar - [20/May/08 05:00 PM ]

I haven't yet tested this myself - reopening the issue.

[ Permlink | « Hide ]

Darren Davison - [02/Jun/08 02:30 AM ]

any news on this - even just to confirm as an issue to be resolved?

[ Permlink | « Hide ]

Scott Farquhar - [02/Jun/08 02:34 AM ]

Haven't managed to confirm anything - just re-opened so that I'll look into it.

[ Permlink | « Hide ]

Mark Stralka - [31/Jul/08 06:58 AM ]

Does anyone know when 2.4 is going to be released into the maven repositories? We need this fix as well