History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SIM-124
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Assignee: Scott Farquhar
Reporter: Matt Raible
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
SiteMesh

URLs with Query Strings cannot be excluded

Created: 14/Aug/04 01:37 PM   Updated: 03/Jul/07 08:55 AM
Fix Version/s: 2.2

Environment: WinXP, JDK 1.4.2, SiteMesh 2.1, Tapestry 3.0, Tomcat 5.0.27, web.xml with 2.4 XSD


 Description  « Hide
The exclude parameter doesn't allow URLs with query strings to be excluded.

I'm trying to exclude the followin Tapestry URL/Page from being
decorated - but it doesn't work.

<decorators defaultdir="/decorators">
     <excludes>
         <pattern>/app?service=direct/1/users/$DirectLink$0</pattern>
     </excludes>
     <decorator name="default" page="default.jsp">
         <pattern>/*</pattern>
     </decorator>
</decorators>

Reason from Joe:

Okay, I think I see what's happening. The SiteMesh filter checks to see whether a page should be excluded by looking at
request.getServletPath(), which does not return anything past the
question mark, so the exclude doesn't work. This be a bug in SiteMesh.

Original thread: http://thread.gmane.org/gmane.comp.web.sitemesh.general/691



 All   Comments   Change History      Sort Order:
Matt Raible - [21/Aug/04 06:21 PM ]
I tried this with the latest snapshot and it's not fixed (yet).

Olivier Vit - [03/Jul/07 08:55 AM ]
Didn't seem to work in 2.2.1 to exclude the homepage when it happen to have a parameter like
http://example.com/?gclid=4654q5s4d55sqd

However, 2.3 seems to works fine

Regards