
|
If you were logged in you would be able to see more operations.
|
|
|
|
I've noticed that in your current logging paradigm that there is a tendency to end up with logging statements in the following manner:
(taken from StdRowLockSemaphore)
getLog().debug("Lock '" + lockName + "' is desired by: " + Thread.currentThread().getName());
From experience this can have a negative performance impact since you have to concatenate the string, before the string is passed to the logger to see if you are even going to bother logging the information.
I would reccomend putting anything that is performing this type of error logging behind a conditional statement to insure that the information is required.
so it would become something like:
if (getLog().isDebugEnabled(){
getLog().debug("Lock '" + lockName + "' is desired by: " + Thread.currentThread().getName());
}
This is fairly straightforward and trivial. If your interested I can probably submit the changes.
|
|
Description
|
I've noticed that in your current logging paradigm that there is a tendency to end up with logging statements in the following manner:
(taken from StdRowLockSemaphore)
getLog().debug("Lock '" + lockName + "' is desired by: " + Thread.currentThread().getName());
From experience this can have a negative performance impact since you have to concatenate the string, before the string is passed to the logger to see if you are even going to bother logging the information.
I would reccomend putting anything that is performing this type of error logging behind a conditional statement to insure that the information is required.
so it would become something like:
if (getLog().isDebugEnabled(){
getLog().debug("Lock '" + lockName + "' is desired by: " + Thread.currentThread().getName());
}
This is fairly straightforward and trivial. If your interested I can probably submit the changes.
|
Show » |
|