History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: QUARTZ-84
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: James House
Reporter: Jason Bailey
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Quartz Scheduler

General Logging Enhancements

Created: 13/Oct/04 10:21 AM   Updated: 23/Nov/04 01:00 PM
Component/s: Core
Affects Version/s: 1.4.2
Fix Version/s: 1.4.3


 Description  « Hide
I've noticed that in your current logging paradigm that there is a tendency to end up with logging statements in the following manner:

(taken from StdRowLockSemaphore)

getLog().debug("Lock '" + lockName + "' is desired by: " + Thread.currentThread().getName());

From experience this can have a negative performance impact since you have to concatenate the string, before the string is passed to the logger to see if you are even going to bother logging the information.

I would reccomend putting anything that is performing this type of error logging behind a conditional statement to insure that the information is required.

so it would become something like:

if (getLog().isDebugEnabled(){
    getLog().debug("Lock '" + lockName + "' is desired by: " + Thread.currentThread().getName());
}

This is fairly straightforward and trivial. If your interested I can probably submit the changes.



 All   Comments   Change History      Sort Order:
James House - [23/Nov/04 01:00 PM ]
suggested change has been made everywhere that it is likely to make a real difference (e.g. where concatination is taking place).