[#QUARTZ-606] RamJobStore.storeTrigger incorrectly removes JobDetail when replacing trigger

Quartz Scheduler

RamJobStore.storeTrigger incorrectly removes JobDetail when replacing trigger

Created: 31/Jul/07 10:23 AM Updated: 07/Sep/07 09:51 AM

Component/s:

Job Stores

Affects Version/s:

None

Fix Version/s:

1.6.1

File Attachments:

QUARTZ-606.patch (4 kb)
2.

RamJobStore_StoreTrigger_Replace_TestCase.txt (1 kb)

Issue Links:

Container

This issue contains:
	~~QRTZNET-27~~ RamJobStore.StoreTrigger incorrectly ...

Description

« Hide

See ~~QRTZNET-27~~

This was fixed by adding private overload that takes parameter deleteOrpahanedJob that default to true and storeTrigger calls it with false. This boolean is then checked when deciding whether to remove job.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Marko Lahma - [31/Jul/07 10:23 AM ]

Attached a test case for RamJobStoreTest that describes the problem

[ Permlink | « Hide ]

Henri Yandell - [04/Sep/07 07:33 AM ]

Patch with Marko's test integrated into the unit tests and a Marko's suggested fix.

[ Permlink | « Hide ]

Henri Yandell - [04/Sep/07 07:33 AM ]

As there's a patch - assigning to 1.6.1 for discussion.

[ Permlink | « Hide ]

Henri Yandell - [07/Sep/07 09:51 AM ]

svn ci -m "Applying the patch from ~~QUARTZ-606~~ based on Marko's suggested change in Quartz.NET" src
Sending src/java/org/quartz/simpl/RAMJobStore.java
Sending src/test/java/org/quartz/simpl/RAMJobStoreTest.java
Transmitting file data ..
Committed revision 722.

svn ci -m "Applying the patch from ~~QUARTZ-606~~ based on Marko's suggested change in Quartz.NET" src
Sending src/java/org/quartz/simpl/RAMJobStore.java
Sending src/test/java/org/quartz/simpl/RAMJobStoreTest.java
Transmitting file data ..
Committed revision 723.