
|
If you were logged in you would be able to see more operations.
|
|
|
|
|
| Component/s: |
Jobs
|
| Affects Version/s: |
1.6
|
| Fix Version/s: |
1.6.1
|
|
|
jobs.ee.jms.SendQueueMessageJob has some simple bugs. i fixed them to match the original intent as well as could see it, is pretty trivial so probably got it right - seems to be working fine. thanks for the original author for providing this! it is a bit strange though that clearly completely untested code has been put to CVS and released.
i have not used JIRA before so don't know if this will let me attach a patch later in the process, so am putting the diff here just in case:
Index: src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java
===================================================================
RCS file: /cvs/quartz/src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java,v
retrieving revision 1.2
diff -u -r1.2 SendQueueMessageJob.java
--- src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java 13 Jul 2006 10:40:53 -0000 1.2
+++ src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java 1 Dec 2006 12:20:52 -0000
@@ -70,7 +70,7 @@
*
* @see JmsMessageFactory
*
-* @author Weston M. Price
+* @author Weston M. Price (little fixes v. in 1.6.0 by Toni Alatalo)
*
*
*/
@@ -91,9 +91,11 @@
final JobDataMap jobDataMap = detail.getJobDataMap();
try {
-
ctx = JmsHelper.getInitialContext(jobDataMap);
+ qcf = (QueueConnectionFactory) ctx
+ .lookup(jobDataMap.getString(JmsHelper.JMS_CONNECTION_FACTORY_JNDI));
+
if(JmsHelper.isDestinationSecure(jobDataMap)) {
String user = jobDataMap.getString(JmsHelper.JMS_USER);
String pw = jobDataMap.getString(JmsHelper.JMS_PASSWORD);
@@ -105,7 +107,7 @@
boolean useTransactions = JmsHelper.useTransaction(jobDataMap);
int ackMode = jobDataMap.getInt(JmsHelper.JMS_ACK_MODE);
session = conn.createQueueSession(useTransactions, ackMode);
- queue = (Queue)ctx.lookup(JmsHelper.JMS_DESTINATION_JNDI);
+ queue = (Queue)ctx.lookup(jobDataMap.getString(JmsHelper.JMS_DESTINATION_JNDI));
sender = session.createSender(queue);
String factoryClass = jobDataMap.getString(JmsHelper.JMS_MSG_FACTORY_CLASS_NAME);
JmsMessageFactory factory = JmsHelper.getMessageFactory(factoryClass);
|
|
Description
|
jobs.ee.jms.SendQueueMessageJob has some simple bugs. i fixed them to match the original intent as well as could see it, is pretty trivial so probably got it right - seems to be working fine. thanks for the original author for providing this! it is a bit strange though that clearly completely untested code has been put to CVS and released.
i have not used JIRA before so don't know if this will let me attach a patch later in the process, so am putting the diff here just in case:
Index: src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java
===================================================================
RCS file: /cvs/quartz/src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java,v
retrieving revision 1.2
diff -u -r1.2 SendQueueMessageJob.java
--- src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java 13 Jul 2006 10:40:53 -0000 1.2
+++ src/java/org/quartz/jobs/ee/jms/SendQueueMessageJob.java 1 Dec 2006 12:20:52 -0000
@@ -70,7 +70,7 @@
*
* @see JmsMessageFactory
*
-* @author Weston M. Price
+* @author Weston M. Price (little fixes v. in 1.6.0 by Toni Alatalo)
*
*
*/
@@ -91,9 +91,11 @@
final JobDataMap jobDataMap = detail.getJobDataMap();
try {
-
ctx = JmsHelper.getInitialContext(jobDataMap);
+ qcf = (QueueConnectionFactory) ctx
+ .lookup(jobDataMap.getString(JmsHelper.JMS_CONNECTION_FACTORY_JNDI));
+
if(JmsHelper.isDestinationSecure(jobDataMap)) {
String user = jobDataMap.getString(JmsHelper.JMS_USER);
String pw = jobDataMap.getString(JmsHelper.JMS_PASSWORD);
@@ -105,7 +107,7 @@
boolean useTransactions = JmsHelper.useTransaction(jobDataMap);
int ackMode = jobDataMap.getInt(JmsHelper.JMS_ACK_MODE);
session = conn.createQueueSession(useTransactions, ackMode);
- queue = (Queue)ctx.lookup(JmsHelper.JMS_DESTINATION_JNDI);
+ queue = (Queue)ctx.lookup(jobDataMap.getString(JmsHelper.JMS_DESTINATION_JNDI));
sender = session.createSender(queue);
String factoryClass = jobDataMap.getString(JmsHelper.JMS_MSG_FACTORY_CLASS_NAME);
JmsMessageFactory factory = JmsHelper.getMessageFactory(factoryClass);
|
Show » |
|