[#QUARTZ-465] A misfire that completes a Trigger does not notify SchedulerListener.triggerFinalized()

Quartz Scheduler

A misfire that completes a Trigger does not notify SchedulerListener.triggerFinalized()

Created: 09/Jun/06 10:00 AM Updated: 07/May/07 01:07 PM

Component/s:

Core

Affects Version/s:

1.6, 1.5.2

Fix Version/s:

1.6.1

File Attachments:

QUARTZ-465-2.patch (0.4 kb)
2.

QUARTZ-465.patch (3 kb)

Description

« Hide

This issue was raised here: http://forums.opensymphony.com/thread.jspa?messageID=65752#65752

In JobStoreSupport.updateMisfiredTrigger()/recoverMisfiredJobs() and RAMJobStore.applyMisfire(), when setting the trigger state to COMPLETE because the Trigger has no next fire time, shouldn't we also call QuartzScheduler.notifySchedulerListenersFinalized(Trigger)?

This would require adding a method to the SchedulerSignaler to expose this to the JobStores (like SchedulerSignaler.notifyTriggerListenersMisfired()).

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Henri Yandell - [30/Apr/07 05:33 PM ]

Patch containing the changes that Jasper was suggesting (I think).

[ Permlink | « Hide ]

Henri Yandell - [07/May/07 01:02 PM ]

Additional change required so things compile. I hadn't done an ant clean.

[ Permlink | « Hide ]

Henri Yandell - [07/May/07 01:07 PM ]

On 1.6 branch:

svn ci -m "Applying patch from ~~QUARTZ-465~~ so that triggerFinalized is notified in the right places" src/
Sending src/java/org/quartz/core/SchedulerSignalerImpl.java
Sending src/java/org/quartz/impl/jdbcjobstore/JobStoreSupport.java
Sending src/java/org/quartz/simpl/RAMJobStore.java
Sending src/java/org/quartz/spi/SchedulerSignaler.java
Transmitting file data ....
Committed revision 707.

AND

svn ci -m "Fixing compile-time error in the first patch for ~~QUARTZ-465~~ (this is the second patch)" src/
Sending src/test/java/org/quartz/simpl/RAMJobStoreTest.java
Transmitting file data .
Committed revision 708.

On trunk:

svn ci -m "Applying patches from ~~QUARTZ-465~~ so that triggerFinalized is notified in the right places" src/
Sending src/java/org/quartz/core/SchedulerSignalerImpl.java
Sending src/java/org/quartz/impl/jdbcjobstore/JobStoreSupport.java
Sending src/java/org/quartz/simpl/RAMJobStore.java
Sending src/java/org/quartz/spi/SchedulerSignaler.java
Sending src/test/java/org/quartz/simpl/RAMJobStoreTest.java
Transmitting file data .....
Committed revision 709.