History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: QUARTZ-355
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: James House
Reporter: Jasper Rosenberg
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Quartz Scheduler

Cleanup QuartzService MBean javadoc

Created: 06/Mar/06 07:41 AM   Updated: 24/Dec/07 01:30 AM
Component/s: None
Affects Version/s: 1.6
Fix Version/s: 1.6


 Description  « Hide
In issue QUARTZ-350, I renamed quartz-service.xml to quartz-service.xml-example, so that it wouldn't be picked up by JBoss automatically.

However, it occured to me that this wasn't the correct solution as doc-files shouldn't be in the archives in the first place, so I fixed it such that:

1. The contents of doc-files directories are not copied to the build directory so they are excluded from the archives (for the compile.features.jboss target).
2. Renamed quartz-service.xml-example back to quartz-service.xml
3. Added an explicit link in the QuartzService and QuartzServiceMBean javadocs to the doc-files/quartz-service.xml file rather than just referencing it by name.



 All   Comments   Change History      Sort Order:
Peter Durcansky - [25/Jul/06 10:30 AM ]
I actually liked sample quartz-service.xml in the quartz-jboss-xxx.jar - it gave me a head start to set up the configuration; but that's just my preference. I understand you do not want to pollute the JAR file.

It would be nice to have a link or the config file location mentioned in the manifest.mf in the archive (if possible).
=============
Another comment: The file contains:
  <classpath codebase="." archives="quartz.jar"/>
I do not think it is hurting (JBoss 3.2.x seems to silently ignore incorrect classpath settings) but the archive parameter is wrong - it will be either quartz-jboss-1.6.0.jar or quartz-all-1.6.0.jar. Perhaps the safe option would be to leave out the <classpath> element in the service definition example (JBoss uses flat classloaders and so just dropping the library in server/<configName>/lib or deploy directory is sufficient).

Peter

Jasper Rosenberg - [25/Jul/06 10:46 AM ]
The quartz-service.xml in the jar was actually causing me problems because JBoss 4 was picking it up (and for example I had had a different name for my quartz datasource). It was never actually intended to be in the jar, and for 1.6 the file is now correctly being included in the javadocs, so it should still be easy to find and use as a starting point.

With regards to the classpath element, I agree it seems unnecessary, and I will remove it.