[#OGNL-6] When setting fields type conversion returning null falsly reports a NoSuchPropertyException

OGNL

When setting fields type conversion returning null falsly reports a NoSuchPropertyException

Created: 21/Sep/06 01:56 AM Updated: 21/May/09 06:41 AM

Component/s:

PropertyAccessors

Affects Version/s:

2.6.9

Fix Version/s:

2.7

File Attachments:

fieldSetNull.diff (4 kB)

Description

« Hide

When calling a method, if type conversion fails (returns null), a parameter is just set to null and then the method is called.

When setting a field, if type conversion (returns null), the field set is skipped altogether and a NoSuchPropertyException is thrown. Instead, the field should be set to null to be parallel with method calling and not report a false exception.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Jesse Kuhnert added a comment - 17/Feb/07 12:37 PM

Need more time to confirm this behavior.

[ Permlink | « Hide ]

Jesse Kuhnert added a comment - 14/Apr/07 01:42 PM

I changed this recently so that if type conversion fails a catchable exception is thrown.

[ Permlink | « Hide ]

Erik Jõgi added a comment - 21/May/09 06:41 AM

I just stumbled on this issue when using OGNL in Struts2. I have a custom TypeConverter that returns null sometimes. This returned value is ignored and a NoSuchPropertyException is thrown.

I agree with the original description that possibility to set null values to a field shoud be supported.

Can you please comment as to why won't you fix this?