[#CORE-76] TextUtils.plainTextToHtml() method EXPLICITLY excludes

OSCore

TextUtils.plainTextToHtml() method EXPLICITLY excludes

Created: 15/Oct/07 02:00 AM Updated: 29/Oct/07 04:03 PM

Component/s:

TextUtils

Affects Version/s:

None

Fix Version/s:

2.2.6

File Attachments:

core-76.patch (5 kB)

Flags:

Important

Description

« Hide

This issue was created based on http://jira.atlassian.com/browse/JRA-13188, where

The TextUtils.plainTextToHtml() method EXPLICITLY excludes dash - as a valid URL character. In fact it also excludes the following characters

. : - / ~

According to http://www.ietf.org/rfc/rfc2396.txt the "-" character is a valid URL character in the given position. As is "." and "~"

However "/" ":" are reserved and hence invalid. Perhaps the OS Core code is being a little too zealous

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Dushan Hanuska added a comment - 15/Oct/07 02:02 AM

Scott asked to be assigned this issue. Since I just created my account at opensymphony.com and do not have permission to assign issues I could not do so :-(

[ Permlink | « Hide ]

Dushan Hanuska added a comment - 15/Oct/07 02:07 AM

Nice, I just realized the typo in the description but I cannot even edit my own issue :-((

[ Permlink | « Hide ]

Chris Mountford added a comment - 18/Oct/07 06:20 PM

The originating problem raised in JIRA ( http://jira.atlassian.com/browse/JRA-13188 ) derives from the fact that tiny url generators use "~" and "-" as possible ends for a URL. Whereas ":" and"." are most likely to be a part of the sentence structure and close parenthesis ")" is, when paired with a preceding open paren "(", the "best guess" spirit of this method is preserved.

By the way, "/" and ":" are *valid* for the path segment of a URL according to the RFC.

[ Permlink | « Hide ]

Chris Mountford added a comment - 18/Oct/07 06:21 PM

I'm sending a patch which removes "-" and "~" from the invalid trailing char list for a detected URL.