Tim Craycroft - [09/Jun/04 02:46 PM ] ServletCacheAdministrator.getCache() calls request.getSession(true) in order to get the ServletContext from the request. The ServletContext is needed to access the application-scope cache. ServletCacheAdministrator instances don't refer directly back to their owning ServletContext, though since the model is one administrator per context, it seems reasonable to do so (unless I'm missing something), and to avoid creating a session to access the context.

Andres March - [27/Jan/05 03:40 PM ] definitely, easy win

Lars Torunski - [28/Jan/05 12:39 PM ] This improvement may change the behaviour of the application, because a session object isn't created anymore even if it wasn't necessary. A web application may react different to a not existing session object.

Hani Suleiman - [03/Feb/05 04:55 AM ] I've committed a fix for this. The reason I think it's fine to have it in is that for anyone who uses a cache tag without specifically turning off sessions, one is created for the jsp page. So the only people who care are those who go out of their way to turn off sessions for a page, and they're the only people who need this fix.

Lars Torunski - [03/Feb/05 08:20 AM ] Should we deprecate the method "public Cache getCache(HttpServletRequest request, int scope)"? Because every FlushTag::doStartTag, ServletCacheAdministrator::cancelUpdate, getFromCache, putInCache and setCacheCapacity will still invoke getCache and a session object will be created. The application should use "getSessionScopeCache" and "getAppScopeCache" instead.

Hani Suleiman - [09/Feb/05 04:03 PM ] I dont think it should be deprecated. Another alternative is to have the admin object hold onto the servletContext, in which case the method could get at the app cache without going through the user session.

Bin Sun - [21/Feb/05 09:20 AM ] As a workaround before 2.1.1 goes out, you may try my patch code described at http://jira.opensymphony.com/browse/CACHE-134