History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CACHE-163
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Won't Fix
Priority: Major Major
Assignee: Lars Torunski
Reporter: Lars Torunski
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OSCache
CacheFilter easier sub-classing (CACHE-141)

CacheFilter easier sub-classing via pre- and post-processes

Created: 10/Apr/05 07:00 AM   Updated: 08/Oct/06 09:03 AM
Component/s: Filters
Affects Version/s: 2.1
Fix Version/s: 2.4


 Description  « Hide
It would be nice to add some improvements to the CacheFilter class in order to make it easier to have a sub-class.

/**
     * doFilterPreProcess is a method allowing subclass to perform actions
     * at the start of the filtering process.
     *
     * @param request The HTTP servlet request
     * @param response The HTTP servlet response
     * @param key The cache key used to access the cache
     * @param cache The cache object
     */
    protected void doFilterPreProcess(HttpServletRequest request,
                                      HttpServletResponse response,
                                      String key,
                                      Cache cache) {
        
if (log.isDebugEnabled()) {
            log.debug("<cache>: doFilter for key " + key + " is starting.");
        }
    }

/**
     * doFilterPostProcess is a method allowing subclass to perform actions
     * at the end of the filtering process.
     *
     * @param request The HTTP servlet request
     * @param response The HTTP servlet response
     * @param key The cache key used to access the cache
     * @param cache The cache object
     */
    protected void doFilterPostProcess(HttpServletRequest request,
                                       HttpServletResponse response,
                                       String key,
                                       Cache cache) {
        if (log.isDebugEnabled()) {
            log.debug("<cache>: doFilter for key " + key + " has been done.");
        }
    }

 All   Comments   Change History      Sort Order:
Lars Torunski - [08/Oct/06 09:03 AM ]
after a lot of code changes and no real use case this issue won't be fixed